#11460: Admin changelist shows no rows with a non-zero count where ForeignKeys
are
used in list_display and data is bad
-------------------------------------------+--------------------------------
Reporter: afitzpatrick | Owner: nobody
Status: reopened | Milestone:
Component: django.contrib.admin | Version: 1.0
Resolution: | Keywords:
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by kmtracey):
I don't know about rejecting this so fast. It's very confusing behavior
for people who happen to have broken data like this (I know I've debugged
it at least once on the user's list, unless there's some other way to get
more results listed than displayed). Sure, best fix is to only have valid
data but saying that doesn't really help anyone who happens to have gotten
themselves into (or inherited) a broken situation. I don't think it's
totally absurd to consider improving the admin behavior here.
However, I don't like the proposed fix of making the admin generate an
exception...bad data should not make the admin fall over and die. I'd
prefer some sort of error message noting the anomaly and hopefully
pointing towards how to fix it. (Actually I'd prefer a display of all
records highlighting the broken ones as broken, but that seems like too
much special-case code for what is hopefully not all THAT common a
problem.)
Wasn't going to reopen because I certainly don't have time to do anything
useful with this, but in the meantime it's been reopened. I'll just note
we prefer to avoid open/close/reopen/close/etc fights in tickets by
raising the issue on the dev list -- this gives it a wider audience than
people who follow the tracker closely. Right now is probably a bad time
to raise an issue like this given the focus on finishing up 1.1, but after
1.1 goes out, and if you can come up with a better answer than making the
admin generate an exception, you might want to pursue that avenue to see
if there's wider support than just me for improving admin's behavior in
this situation.
--
Ticket URL: <http://code.djangoproject.com/ticket/11460#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
