#5515: Custom Permission Denied Pages
----------------------------------------------------------------+-----------
          Reporter:  Piotr Lewandowski <dja...@icomputing.biz>  |         
Owner:     
            Status:  reopened                                   |     
Milestone:     
         Component:  Contrib apps                               |       
Version:  SVN
        Resolution:                                             |      
Keywords:     
             Stage:  Design decision needed                     |     
Has_patch:  1  
        Needs_docs:  0                                          |   
Needs_tests:  0  
Needs_better_patch:  0                                          |  
----------------------------------------------------------------+-----------
Comment (by lukeplant):

 Sorry, I saw a non-i18n-ized template in the patch, but that was just for
 the tests.

 Like Jacob, I've got concerns about whether this is the right thing.  In
 favor of the ticket, it is probably a good idea to allow the user to
 customise any user visible response that is returned by Django core code,
 which means providing some way of giving a template for
 HttpPermissionDenied errors.

 Also as the patch stands, I don't like the backwards incompatibility -
 developers have to create a template for 403s to continue to work.
 Hardcoding a simple fallback template (possibly in
 django/views/defaults.py itself) would solve that, even if it doesn't feel
 very nice.

 To summarise, we need to:

 * discuss whether this is the right thing
 * remove CSRF stuff from patch
 * sort out backwards compatibility for 403s.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5515#comment:16>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to