#11696: validate command in 1.1 hides errors in models that used to be shown
------------------------------------+---------------------------------------
Reporter: martin maney | Owner: nobody
Status: new | Milestone:
Component: Uncategorized | Version: 1.1
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
------------------------------------+---------------------------------------
Changes (by martin maney):
* has_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
Looks simple enough. At a guess the try/except wrapper was thrown
together to satisfy the case where it could be postponed and error
reporting was simply not considered. This works for me in a small test
case (validates OK with a small existing app, get the traceback when I
inject a misspelt field type name). Unless there's some subtle problem
with the postponing business, I think this will do.
{{{
try:
models = import_module('.models', app_name)
except ImportError, e:
self.nesting_level -= 1
if can_postpone:
# Either the app has no models, or the package is still
being
# imported by Python and the model module isn't available
yet.
# We will check again once all the recursion has finished
(in
# populate).
self.postponed.append(app_name)
return None
raise e
self.nesting_level -= 1
}}}
--
Ticket URL: <http://code.djangoproject.com/ticket/11696#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
