#10057: ModelAdmin.render_change_form should not override the 'has_delete' option -------------------------------------------+-------------------------------- Reporter: rajeesh | Owner: nobody Status: reopened | Milestone: Component: django.contrib.admin | Version: SVN Resolution: | Keywords: ModelAdmin render_change_form Stage: Unreviewed | Has_patch: 1 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | -------------------------------------------+-------------------------------- Changes (by patcoll):
* status: closed => reopened * resolution: wontfix => Comment: Just ran into the same problem. The logic that produces a `True` or `False` for `show_delete_link` in `django.contrib.admin.templatetags.admin_modify seems a bit flawed because the value of `show_delete` in the passed context is essentially always ignored because the `changed` boolean is hard-coded to True by the admin system if you are viewing the `change_view` with a bound Form. I've attached a patch that ensures that `show_delete` is checked if it exists, otherwise it always displays the delete link. -- Ticket URL: <http://code.djangoproject.com/ticket/10057#comment:5> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---