#11956: ReverseManyRelatedObjectsDescriptor wrongly assumes symmetry between inherited objects ---------------------------------------------------+------------------------ Reporter: nidi | Owner: nobody Status: new | Milestone: Component: Database layer (models, ORM) | Version: 1.1 Resolution: | Keywords: Stage: Unreviewed | Has_patch: 0 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | ---------------------------------------------------+------------------------ Comment (by astoneman):
I just ran into this, and it seems odd to me that the default value for symmetrical is decided on a per-instance basis, when the related manager is created, rather than just once, when the field is created. Would it make more sense to change django/db/models/fields/related:804 (in !ManyToManyField.!__init!__) from: {{{ symmetrical=kwargs.pop('symmetrical', True), }}} to something like: {{{ symmetrical=kwargs.pop('symmetrical', to == RECURSIVE_RELATIONSHIP_CONSTANT), }}} and then assume it's set correctly farther in, and just remove the isinstance check on line 609? -- Ticket URL: <http://code.djangoproject.com/ticket/11956#comment:2> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-upda...@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.