#399: Bigint field object needed ---------------------------------------------------+------------------------ Reporter: jmad...@techie.com | Owner: permon Status: assigned | Milestone: 1.2 Component: Database layer (models, ORM) | Version: SVN Resolution: | Keywords: sprintsept14, bigint Stage: Accepted | Has_patch: 1 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | ---------------------------------------------------+------------------------ Comment (by kmtracey):
I've reviewed the existing patch and uploaded a new one. Primary difference is that I removed the limit testing done during save. No other fields do this kind of validation during save and it seems highly inconsistent to add one field that has this one specific kind of test (without testing for other bad things, like attempting to save floats, for example). It is true that the behavior if you attempt to save outside the limits is ugly and inconsistent from db to db, but it's consistent with how other existing fields behave. The right way to fix it, consistently for all fields, would be in something like model validation, I think, which is beyond the scope of this ticket. I did, however, leave in the formfield that sets max and min limits. This too is a bit inconsistent with other fields, but for some reason it does not bother me as much, perhaps because it limits the likelihood of a user encountering the ugliness resulting from not validating during save. I also added some doc and put the existing doc for the new field in alphabetical order rather than making it a subtype under the doc for !IntegerField. That's an implementation detail I don't believe needs to be exposed in the user doc. -- Ticket URL: <http://code.djangoproject.com/ticket/399#comment:71> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-upda...@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.