#12596: Calling ModelForm.clean() is no longer optional
--------------------+-------------------------------------------------------
Reporter: carljm | Owner: carljm
Status: new | Milestone:
Component: Forms | Version: 1.1
Keywords: | Stage: Unreviewed
Has_patch: 0 |
--------------------+-------------------------------------------------------
It's [[documented
http://docs.djangoproject.com/en/1.1/topics/forms/modelforms/#overriding-
the-clean-method]] that if you override clean() on a ModelForm and fail to
call ModelForm's clean() method, all you lose is validate_unique. With the
recent model validation changes, this is no longer true; ModelForm.clean
does quite a bit more (including constructing self.instance), and failing
to call it will almost certainly break things.
Per discussion with jkocherhans in IRC, it should be possible to rearrange
things to maintain the previously documented behavior.
--
Ticket URL: <http://code.djangoproject.com/ticket/12596>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
