#11764: Bugfix: typo with avoid.update(..) in
db/models/sql/compiler.py:SQLCompiler:fill_related_selections
---------------------------------------------------+------------------------
Reporter: aurelio | Owner: ramiro
Status: assigned | Milestone: 1.2
Component: Database layer (models, ORM) | Version: SVN
Resolution: | Keywords:
Stage: Ready for checkin | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------------+------------------------
Comment (by ramiro):
Replying to [comment:3 wogan]:
> Updated patch as the typo had moved from
[source:django/trunk/django/db/models/sql/query.py query.py] to
[source:django/trunk/django/db/models/sql/compiler.py compiler.py].
Thanks for updating the patch. I had spotted the code move and implemented
a simliar updating locally. Problem is that the regression test case I had
added now pass with and without the fix applied. I ran the full Django
test suite with code coverage analysis turned on and it shows that exact
code path isn't exercised anymore.
This means we need to update the test because the core committers won't
get this change in without a regression test. But I don't know if it's
possible at all.
Sorry for not updating the ticket, I only made a comment about this on the
`#django-dev` IRC channel.
--
Ticket URL: <http://code.djangoproject.com/ticket/11764#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
