#12915: formfield_callback is lost in an inherited ModelForm
---------------------------------+------------------------------------------
Reporter: semenov | Owner: nobody
Status: new | Milestone:
Component: Forms | Version: 1.1
Resolution: | Keywords:
Stage: Unreviewed | Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------+------------------------------------------
Comment (by semenov):
No, changing pop() to get() doesn't help. That does store a manually
specified formfield_callback for a class; but that doesn't lookup a
missing formfield_callback from a parent. Moreover, it will break on a
double inheritance chain, e.g. when class A(ModelForm) stores a
formfield_classback, class B(A) doesn't store but still can lookup parent,
then class C(B) can't even lookup since B didn't store formfield_callback.
I am attaching a patch which adds the desired behavior accurately. Please
let me know if it's of any interest to commiters and I will come up with a
regression test.
--
Ticket URL: <http://code.djangoproject.com/ticket/12915#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
