#6510: get_nodes_by_type refactor for easier extensibility (fixes an underlying
bug for IfEqualNode and IfChangedNode)
---------------------------------------------+------------------------------
Reporter: a...@adammckaig.com | Owner: SmileyChris
Status: assigned | Milestone:
Component: Template system | Version: SVN
Resolution: | Keywords: block ifequals
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------+------------------------------
Comment (by russellm):
Summarizing a discussion with SmileyChris on IRC:
The original problem that is alluded to (inconsistency between if and
ifequal) no longer exists. The tests from the first patch (6510.diff) pass
without any code modifications.
The current proposal in this ticket is to refactor and clean up the way
child nodes are handled in template nodes, especially with the
get_nodes_by_type() call. Calls to get_nodes_by_type() currently fail on
ifequal and ifchanged nodes due to some inconsistencies in implementation.
This doesn't have any obvious external manifestations, but in the
interests of everything working consistently and avoiding nasty surprises
later on, SmileyChris' patch does some cleanup.
--
Ticket URL: <http://code.djangoproject.com/ticket/6510#comment:16>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
