#13513: _collect_sub_objects() does not take the database into the account
---------------------------------------------------+------------------------
          Reporter:  gavoja                        |         Owner:  nobody
            Status:  closed                        |     Milestone:        
         Component:  Database layer (models, ORM)  |       Version:  SVN   
        Resolution:  wontfix                       |      Keywords:        
             Stage:  Unreviewed                    |     Has_patch:  1     
        Needs_docs:  0                             |   Needs_tests:  0     
Needs_better_patch:  0                             |  
---------------------------------------------------+------------------------
Changes (by russellm):

  * status:  new => closed
  * needs_better_patch:  => 0
  * resolution:  => wontfix
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I'm not sure I see what this patch is trying to achieve. The delete query
 must be executed on a write-enabled database, but you should be able to
 retrieve the list of objects to be deleted from any read-enabled database.
 The only way I can see that this might fail is if your routing rules
 aren't consistent - that is, if the db_for_read() and db_for_write() don't
 return compatible databases, but in this case, you have bigger problems. I
 can't see any obvious reason that the deleted object set needs to be
 retrieved from a write database.

 Of course, I could be wrong, but you don't provide a test case that
 validates under what conditions this problem would manifest itself.

 Closing wontfix; If you can provide a test case under which deletion is
 problematic -- even a description of a set of circumstances -- please
 reopen.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/13513#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to