#5390: Add signals to ManyRelatedManager
----------------------------------------------------------+-----------------
          Reporter:  Ludovico Magnocavallo <l...@qix.it>  |         Owner:  
rvdrijst                       
            Status:  closed                               |     Milestone:  1.2 
                           
         Component:  Database layer (models, ORM)         |       Version:  SVN 
                           
        Resolution:  fixed                                |      Keywords:  
manytomanyfield feature signals
             Stage:  Design decision needed               |     Has_patch:  1   
                           
        Needs_docs:  0                                    |   Needs_tests:  0   
                           
Needs_better_patch:  1                                    |  
----------------------------------------------------------+-----------------
Comment (by frans):

 I certainly don't want to be a killjoy but it looks like r12223 still uses
 the following for set()
 {{{
 #!python
 manager.clear()
 manager.add(*value)
 }}}
 instead of
 {{{
 #!python
         previous=set(manager.all())
         new=set(value)
         if not new:
           manager.clear()
         else:
           added=new-previous
           removed=previous-new
         if added :
           manager.add(*added)
         if removed :
           manager.remove(*removed)
 }}}
 which may lead, unless I'm missing something, to the problems listed in
 [comment:40:ticket:5390 my initial comment] and [comment:52:ticket:5390
 Xiaket's]

 If this is right, should we reopen the ticket?

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5390#comment:60>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to