#3400: Support for lookup separator with list_filter admin option
-------------------------------------------+--------------------------------
          Reporter:  n...@intv.com.au      |         Owner:  DrMeers            
                                         
            Status:  assigned              |     Milestone:  1.3                
                                         
         Component:  django.contrib.admin  |       Version:  newforms-admin     
                                         
        Resolution:                        |      Keywords:  edc nfa-someday 
list_filter FilterSpec nfa-changelist ep2008
             Stage:  Accepted              |     Has_patch:  1                  
                                         
        Needs_docs:  0                     |   Needs_tests:  0                  
                                         
Needs_better_patch:  0                     |  
-------------------------------------------+--------------------------------
Changes (by DrMeers):

  * owner:  jakub_vysoky => DrMeers
  * needs_better_patch:  1 => 0
  * status:  new => assigned
  * needs_tests:  1 => 0

Comment:

 OK, here is my draft patch. I have not tested it thoroughly; there may
 still be a few issues to smooth out, so test-drivers would be appreciated.

 A few notes:

     * Reverse relationships work
     * You can now use any field path that search_filters will accept
     * I have removed the strict validation in favour of letting
 setup_joins catch any issues, as search_fields does. We could perhaps look
 at adding admin validation for field paths for both instead.
     * I played around with combining multiple limit_choices_to clauses
 based on the models in the field path, however discovered that in practise
 it really doesn't make sense to apply any before the final model in the
 field path
     * limit_choices_to is respected for AllValuesFilterSpec, and a utility
 function is provided if other filterspecs wish to do likewise
     * There are some basic tests included in the patch

-- 
Ticket URL: <http://code.djangoproject.com/ticket/3400#comment:57>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to