#14354: Check password is not None in User.check_password
-------------------------------------+--------------------------------------
Reporter: berryp | Owner: nobody
Status: new | Milestone:
Component: Authentication | Version: 1.2
Resolution: | Keywords:
Stage: Accepted | Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------+--------------------------------------
Changes (by gabrielhurley):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
Comment:
Seems like a valid point to me. I think it might be a little cleaner to
alter `has_usable_password` to check for whatever cases are invalid
(UNUSABLE_PASSWORD, None, ''), and then call `has_usable_password`
internally.
Also, this should definitely have a test case. For bonus points, since
Django is slowly trying to eliminate doctests, you could convert the
contrib.auth.tests.basic test case into a unit test (it's not that many
lines).
--
Ticket URL: <http://code.djangoproject.com/ticket/14354#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
