#14365: Make template-rendering signals available also in DEBUG mode
----------------------------------------+-----------------------------------
Reporter: carljm | Owner: carljm
Status: new | Milestone:
Component: Testing framework | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 0
Needs_better_patch: 1 |
----------------------------------------+-----------------------------------
Changes (by carljm):
* needs_better_patch: 0 => 1
Comment:
Actually, on further review, this patch needs more work. I used a class
attribute on Template to avoid a check every time a template is
instantiated, but introducing an import-time settings dependency is not
OK.
Given that there's already a TEMPLATE_DEBUG check in Template.__init__, I
can probably piggyback on that with almost zero perf impact (I'll
benchmark, of course), and having the API be via an arg to
Template.__init__ (defaulting to TEMPLATE_DEBUG) is nicer than a class
attribute (which is basically a global). Just need to figure out how to
allow the test system to force it to True...
--
Ticket URL: <http://code.djangoproject.com/ticket/14365#comment:5>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
