#9964: Transaction middleware closes the transaction only when it's marked as dirty ---------------------------------------------------+------------------------ Reporter: ishirav | Owner: mtredinnick Status: assigned | Milestone: 1.3 Component: Database layer (models, ORM) | Version: 1.0-beta-1 Resolution: | Keywords: transactions Stage: Accepted | Has_patch: 1 Needs_docs: 1 | Needs_tests: 0 Needs_better_patch: 0 | ---------------------------------------------------+------------------------ Comment (by shai):
Replying to [comment:31 Xof]: > > The current behavior is not a documented, reliable behavior > This is not exactly accurate; the current behavior w.r.t. "modifying without telling Django" is in fact [http://docs.djangoproject.com/en/1.2/topics/db/sql/#transactions-and-raw- sql documented]. Granted, this is one piece of documentation I will be all for removing. > > behavior that we need to continue to support. > The change has performance implications. Of course, performance is not a "documented behavior", but it is not behavior you're free to modify at will either. I grant you that the performance implications are unclear, and doing the right thing may actually perform better in most places where it matters (though evidence for this should be provided); I also agree that, if forced to choose, the correctness considerations outweigh the performance issues here by far. I was just not convinced that forcing this choice is the best option. -- Ticket URL: <http://code.djangoproject.com/ticket/9964#comment:32> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-upda...@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.