#14446: auth.views.password_reset_confirm should never be cached
----------------------------------------+-----------------------------------
Reporter: PaulM | Owner: PaulM
Status: new | Milestone: 1.3
Component: Authentication | Version: 1.2
Resolution: | Keywords:
Stage: Ready for checkin | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------+-----------------------------------
Changes (by gabrielhurley):
* needs_better_patch: => 0
* stage: Unreviewed => Ready for checkin
* needs_tests: => 0
* needs_docs: => 0
Old description:
> I'm splitting this issue off from #14105, as it is separate from the meat
> of that ticket.
>
> `Django.contrib.auth.views.password_reset_confirm` needs the
> `never_cache` decorator.
>
> To reproduce:
> {{{
> 1. Start a new project. Add django.contrib.admin and setup a sqlite
> database. Test result: OK.
>
> 2. Add the required cache settings and the update/fetch middleware. Tests
> result: FAILED (failures=1, errors=27)
> }}}
>
> This issue is that single failure.
New description:
I'm splitting this issue off from #14105, as it is separate from the meat
of that ticket.
`Django.contrib.auth.views.password_reset_confirm` needs the `never_cache`
decorator.
To reproduce:
{{{
1. Start a new project. Add django.contrib.admin and setup a sqlite
database. Run manage.py test auth. Result: OK.
2. Relevant bits of settings.py:
MIDDLEWARE_CLASSES = (
'django.middleware.cache.UpdateCacheMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.cache.FetchFromCacheMiddleware,
)
CACHE_BACKEND = 'locmem://'
Run manage.py test auth. Result: (failures=1, errors=11)
}}}
This issue is that single failure.
Comment:
I can confirm that this patch fixes this test failure, specifically:
{{{
======================================================================
FAIL: test_confirm_valid
(django.contrib.auth.tests.views.PasswordResetTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Development\django\trunk\django\contrib\auth\tests\views.py",
line 91, in test_confirm_valid
self.assert_("Please enter your new password" in response.content)
AssertionError: False is not True
----------------------------------------------------------------------
}}}
The other 11 errors remaining when running the tests under these
conditions are still related to #14105.
Updated the description to make it easier to duplicate if anyone else
wants to check it prior to committing. Marking as RFC.
--
Ticket URL: <http://code.djangoproject.com/ticket/14446#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
