#15067: base36_to_int returns a long in certain situations
-------------------------------------+--------------------------------------
Reporter: Garthex | Owner: nobody
Status: new | Milestone: 1.3
Component: Core framework | Version: 1.2
Resolution: | Keywords: blocker
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------+--------------------------------------
Changes (by kfrazier):
* has_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
Limiting it to 12 characters would ensure that the return value is an int,
but for 32-bit systems, it is far too large. For 32-bit systems, it would
need to be limited to 5 characters. We discussed changes to throw a
ValueError from base36_to_int if the value is greater than sys.maxint, but
that would potentially break a lot of user systems that may be happily
using longs without issue. The safest approach seems to be to just catch
the OverflowError in password_reset_confirm and set user to None if it
occurs. Patch is attached.
--
Ticket URL: <http://code.djangoproject.com/ticket/15067#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
