#15179: django.test.client.Client.login fake HttpRequest is not run through
middlewares
---------------------------------------------+------------------------------
Reporter: Ciantic | Owner: nobody
Status: new | Milestone: 1.3
Component: Testing framework | Version: SVN
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
---------------------------------------------+------------------------------
Changes (by russellm):
* needs_better_patch: 0 => 1
* needs_tests: 1 => 0
* stage: Unreviewed => Accepted
Comment:
Accepting the use case. However, the patch needs some work.
* The patch should note that the reference to "/login" is arbitrary --
it's not actually using /login, it's just using that URL as a dummy
location.
* The test case isn't particularly good - it's checking a test condition
that is a composite of multiple features. You should be checking that
request has an attribute called "middlewares", and that the value is
"+middlewares'. Checking a comparison of concatenated strings is just
confusing the issue.
* The test case should be integrated with Django's test suite (the
test_client_regress tests would be a good location).
--
Ticket URL: <http://code.djangoproject.com/ticket/15179#comment:5>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
