#15214: CharField's widget_attrs should return an empty dict rather than None -------------------+-------------------------------------------------------- Reporter: gg | Owner: gg Status: new | Milestone: Component: Forms | Version: SVN Keywords: | Triage Stage: Unreviewed Has patch: 0 | -------------------+-------------------------------------------------------- See http://code.djangoproject.com/browser/django/trunk/django/forms/fields.py#L217
When `self.max_length` is `None` or `widget` is not a `TextInput` or `PasswordInput` instance, no return value is specified. Returning None can break things when a dict is expected. Theoretically, it should probably call the superclass' widget_attrs and update the dict with its own values (if the conditions are met). In practice, I'm not sure the super call really matters. -- Ticket URL: <http://code.djangoproject.com/ticket/15214> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.
