#6880: django.http.get_host() breaks reverse proxying on apache
--------------------------------------------------+-------------------------
Reporter: Kellen | Owner: nobody
Status: new | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords: redirect
httpresponseredirect get_host reverse proxy squid apache
Triage Stage: Design decision needed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
--------------------------------------------------+-------------------------
Comment (by aaugustin):
#9064 shows that it is complicated to interpret `X-FORWARDED-HOST` when
there is more than one proxy. It is also unnecessary when the proxies are
properly configured. So it may be a good idea to drop it. That would close
both this bug and #9064.
Attached patch:
- no longer interprets the `X-FORWARDED-HOST` header, as suggested in
#6548, #9064, and `get_hostpatch.txt` posted by Kellen above,
- removes a complicated warning in the docs about that header.
This will certainly not make it in 1.3 so `versionchanged` must be changed
to something other than 1.3 when applying the patch.
Obviously, that would be slightly backwards incompatible, but `get_host`
is already broken anyway for people who expect it to handle proxies. Is it
necessary to mention it in the release notes?
--
Ticket URL: <http://code.djangoproject.com/ticket/6880#comment:9>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
