#2550: [patch] Allow a Backend to Globally Fail Authentication
--------------------------------------------+-------------------------------
Reporter: umbrae@… | Owner: aashu_dwivedi
Status: new | Milestone:
Component: Contrib apps | Version: SVN
Resolution: | Keywords: authentication
backends easy-pickings
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 0
Patch needs improvement: 1 |
--------------------------------------------+-------------------------------
Changes (by lrekucki):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
* needs_docs: 0 => 1
Comment:
Yes, otherwise people won't even know the feature is available.
Some comments to the patch:
* Your tests fail (did you runned them?):
{{{
Traceback (most recent call last):
File "/home/lrekucki/django/django-
gh/django/contrib/auth/tests/auth_backends.py", line 388, in
test_authenticates
self.assertEqual(authenticate(username='test',password='test'),self.user1)
NameError: global name 'authenticate' is not defined
}}}
* Some of your code (like "except PermissionDenied" in
{{{django/contrib/__init__.py}}}) is indented with tabs. Mixin spaces and
tabs is bad. Django prefers 4 spaces as indentation.
* You should also format your code according to PEP8 (i.e. whitespace
around operators, whitespace after comma in argument list).
--
Ticket URL: <http://code.djangoproject.com/ticket/2550#comment:10>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
