#15696: Add pre_insert signal to loaddata command
-------------------------------------+-------------------------------------
               Reporter:  jonash     |        Owner:  nobody
                   Type:  New        |       Status:  new
  feature                            |    Component:  Core (Serialization)
              Milestone:             |     Severity:  Normal
                Version:  SVN        |     Keywords:  nonrel
             Resolution:             |    Has patch:  1
           Triage Stage:  Accepted   |  Needs tests:  0
    Needs documentation:  1          |
Patch needs improvement:  1          |
-------------------------------------+-------------------------------------
Changes (by russellm):

 * needs_better_patch:  0 => 1


Comment:

 I disagree that a signal is the right way to handle this. Signals, even
 when unconnected, have a cost, and this would impose a cost on every
 fixture load (and, by extension, every test in every test run) in order to
 support what seems to be to be an extreme edge case requirement.

 My gut tells me that a better approach would be a custom serializer. That
 would isolate the extra cost to the specific deserializer that needs the
 extra data conversion features.

 Answering your question about tests: the tests should go in the
 regressiontests/fixtures_regress  test suite; the loaddata command is
 tested there as a side effect of testing fixtures themselves.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/15696#comment:7>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to