#15573: runtests.py sets incorrect SITE_ID when using Oracle
------------------------------------+-----------------------------------
Reporter: ikelly | Owner: nobody
Type: Bug | Status: closed
Milestone: | Component: Testing framework
Version: SVN | Severity: Normal
Resolution: fixed | Keywords: oracle site_id
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
------------------------------------+-----------------------------------
Changes (by carljm):
* easy: => 0
Comment:
This change broke running of tests in a project without contrib.sites
installed (#15850), due to the underlying issue #15866. I've fixed #15866
in trunk, but wasn't planning to backport to 1.3.X for stability reasons,
since #15866 itself is not a regression and the fix changes the behavior
of (internal and undocumented) methods in a backwards-incompatible way.
However, #15850 is a significant regression and still needs fixing in
1.3.X. I think the least-invasive approach there will be to modify the
change made in r16028 to check INSTALLED_APPS for django.contrib.sites
rather than using the return value of get_model. I don't feel comfortable
making that change myself, though, since I don't have Oracle available to
ensure that the fix still works for the original purpose.
Ian, would you be able to make that change in 1.3.X?
--
Ticket URL: <http://code.djangoproject.com/ticket/15573#comment:8>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
