#5833: Custom FilterSpecs
-------------------------------------+-------------------------------------
               Reporter:             |          Owner:  jkocherhans
  Honza_Kral                         |         Status:  assigned
                   Type:  New        |      Component:  contrib.admin
  feature                            |       Severity:  Normal
              Milestone:             |       Keywords:  nfa-someday
                Version:  SVN        |  list_filter filterspec nfa-
             Resolution:             |  changelist ep2008
           Triage Stage:  Accepted   |      Has patch:  1
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
-------------------------------------+-------------------------------------

Comment (by julien):

 Thanks Jannis! All your changes make sense. I've made a few more changes
 in the latest patch:

 * Renamed `contrib.admin.filterspecs` to `contrib.admin.filters`. Feels
 cleaner and makes more sense now that we've renamed everything from
 `FilterSpec` to `ListFilter`.
 * Removed references to parameter slugification in doc and code comments.
 * `ChangeList.get_query_set()` now receives the `request` as parameter
 (instead of setting a request attribute to the `ChangeList` object as
 introduced in patch 7).
 * Added tests to ensure that `title` and `parameter_name` are correctly
 defined.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:125>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to