#11868: Multiple sort in admin changelist
-------------------------------------+-------------------------------------
Reporter: | Owner: bendavis78
bendavis78 | Status: assigned
Type: New | Component: contrib.admin
feature | Severity: Normal
Milestone: 1.4 | Keywords: admin sort
Version: SVN | multisort ordering order
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Changes (by lukeplant):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* milestone: => 1.4
Comment:
The bug I mentioned turned out to be a separate bug in existing
functionality, fixed in [16312]. I will upload an updated patch that
address the i18n issues neglected in my last patch.
Regarding showing 'ascending' or 'descending' on the popup, I don't know
if I can come up with a method that is i18n friendly. I don't think we can
assume that doing:
{{{
* Field name (ascending)
}}}
is going to look right in all languages (does Arabic use brackets like
that, for instance?). So it's probably best to leave that for now.
I've have tried and failed to write some sensible tests. You can write
tests that test the implementation, rather than functionality, but that is
not useful. If you try to test functionality i.e. click link on first
column, then second column, you get into a regex parsing nightmare, or a
DOM traversal nightmare. To code "click on the link inside the header than
contains the text 'Field name'" succinctly and robustly, you need a
library/infrastructure that Django's test suite just doesn't provide. I
already found in [16313] that I had to remove a test because of fragility.
So, I'm removing 'needs tests'. Just awaiting some UI review now, and a
better icon - help appreciated!
--
Ticket URL: <https://code.djangoproject.com/ticket/11868#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
