#16234: Strange platform-specific test failure in OldFormForXTests since r16366
------------------------------------+------------------------------
Reporter: erikr | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Core (Other)
Version: SVN | Severity: Normal
Resolution: | Keywords: ipv6
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+------------------------------
Changes (by kmtracey):
* stage: Unreviewed => Accepted
Comment:
I was seeing this on Ubuntu 10.04, Python 2.6.5 (not tried anywhere else);
r16390 fixes it for me. I'm pretty sure that's the right fix but not
entirely certain; I'm a little confused that seeing this seems to be
limited to only some systems. The new GenericIPAddressField is modifying
`self.default_error_messages` in `__init__` but it has not declared that
attribute at the class level, so the change is affecting the parent Field
class. At first I thought to override just a single key in that dict the
subclass should copy the dict, but on further looking I think this code:
https://code.djangoproject.com/browser/django/trunk/django/db/models/fields/__init__.py#L115
takes care of gathering up all the key/values specified in all
superclasses. But it's late and I could be missing something, so I put
refs in the commit in stead of fixes. Anyone more awake than me feel free
to review and either close this as fixed or explain what the right fix
should be.
--
Ticket URL: <https://code.djangoproject.com/ticket/16234#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
