#16516: Blocktrans should tolerate bad locale data
-------------------------------------+-------------------------------------
               Reporter:  simon29    |          Owner:  nobody
                   Type:             |         Status:  new
  Cleanup/optimization               |      Component:
              Milestone:             |  Internationalization
                Version:  1.3        |       Severity:  Normal
             Resolution:             |       Keywords:
           Triage Stage:  Accepted   |      Has patch:  1
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------

Comment (by aaugustin):

 To apply the patch, I first removed the chunk about the binary .mo file,
 and then I ran: `msgfmt -o
 tests/regressiontests/i18n/other/locale/fr/LC_MESSAGES/django.mo
 tests/regressiontests/i18n/other/locale/fr/LC_MESSAGES/django.po`

 The fix and the tests for the original issue are OK. You're right,
 `TEMPLATE_STRING_IF_INVALID` isn't a good idea here.

 Regarding the changes to `translation.override`, I don't understand why
 you added the `deactivate`; it isn't used anywhere by this patch; is it a
 fix for a separate issue?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16516#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to