#16645: OldFormForXTests.test_image_field fails under Oracle
-------------------------------------+---------------------------------
               Reporter:  aaugustin  |          Owner:  nobody
                   Type:  Bug        |         Status:  new
              Milestone:             |      Component:  Forms
                Version:  1.3        |       Severity:  Release blocker
             Resolution:             |       Keywords:  oracle
           Triage Stage:  Accepted   |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+---------------------------------

Comment (by aaugustin):

 IRC discussion about this patch:
 {{{
 2011-08-28 15:36:35 <cramm> about the test failure with Oracle 11 related
 to a nullable filefield
 2011-08-28 15:37:18 <cramm> I've been reviewing it. I don't feel
 comfortable with adapting the tests to workaround that
 2011-08-28 15:38:37 <cramm> I konw there is some recommendation in the
 charfield docs discouraging using null=True, but we have a handful of
 models with FileField's and ImageField with null=tru in out tests, and
 they work correctly
 2011-08-28 15:39:57 <cramm> ... and a bunch of models with other
 CharField-derived fields also with null=True. In some tests we even test
 for ORM behavior when confronted with the null=Tree
 2011-08-28 15:40:42 <mYk> cramm: the problem here is that we test that an
 ImageField with no value has its name set to ''
 2011-08-28 15:40:47 <cramm> So, I'd prefer to see first why things don't
 fail in 10g and fail in 11g
 2011-08-28 15:41:03 <mYk> but since the field is nullable the result
 should be None
 2011-08-28 15:41:47 <mYk> the docs don't say exactly how <file>.name is
 supposed to behave, but basically, it's the string stored in the db
 2011-08-28 15:42:46 <mYk> in short, I agree that I didn't nail the root
 cause, and the expected behavior of <file>.name is underdefined
 2011-08-28 15:43:09 <cramm> I gree with the latter :)
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16645#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to