#16803: Unicode representation of ContentType instances is not translated
------------------------------------+--------------------------------------
Reporter: bronger | Owner: isagalaev
Type: Bug | Status: assigned
Milestone: | Component: contrib.contenttypes
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+--------------------------------------
Changes (by carljm):
* needs_better_patch: 0 => 1
Comment:
Replying to [comment:6 isagalaev]:
> Here's the first iteration of a patch. A couple of notes:
>
> * {{{touch tests/regressiontests/i18n/contenttypes/__init__.py}}}
> * I don't know if there a point of attaching compiled language files
that don't get included in the patch, it might be easier to compile them
from tests/regressiontests/i18n/contenttypes directory by hand
> * I left a comment in django/contrib/contenttypes/models.py regarding
deprecation of {{{self.name}}} but wasn't sure if we should actually raise
a DeprecationWarning there?
I think actual deprecation of the name field should wait until we have
schema migrations in core, so that we can actually remove the field at the
end of the deprecation. For now the comment is fine - I might expand on it
to note that we'll do a real deprecation later.
Looks good otherwise, except I'm now getting four UnicodeDecodeErrors in
the admin_views tests with this patch. Probably due to the added
translation with non-ASCII chars in it, haven't dug in to find the best
solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/16803#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
