#17011: Recursion error in TestCase class decorated by override_settings when
overriding method on parent class and calling parent method
-----------------------------------+------------------------------------
     Reporter:  jsdalton           |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  SVN
     Severity:  Normal             |               Resolution:
     Keywords:                     |             Triage Stage:  Accepted
    Has patch:  1                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------
Changes (by jsdalton):

 * needs_better_patch:  1 => 0


Comment:

 Thanks Carl. I think you are correct, monkey patching in this case is
 cleaner and less prone to weirdness. I moved the the tests I had created
 to `settings_tests` and worked the implementation. `settings_tests` all
 pass.

 I filed the patch as a pull request, hopefully I'm doing this right:

 https://github.com/django/django/pull/60

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17011#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to