#14580: Cleaning up duplicate code in the admin, add get_formsets_instances
--------------------------------------+------------------------------------
Reporter: apollo13 | Owner: nobody
Type: Cleanup/optimization | Status: reopened
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by carljm):
* status: closed => reopened
* resolution: fixed =>
Comment:
The fix for #8060 did touch some of this code, and would require minor
updates to this patch, but unless I'm missing something I don't think it
actually fixed the duplication this ticket was addressing. It added a
`get_inline_instances` method, because the inline instances are now
permissions-dependent rather than static; but the actual code that creates
formsets based on those inline instances is still duplicated with minor
differences several different places in `add_view` and `change_view`. I
noticed that duplication in working on #8060 and I still think it'd be
good to clean it up if we can, so I'd like to leave this ticket open until
we do so.
--
Ticket URL: <https://code.djangoproject.com/ticket/14580#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
