#17040: In utils.crypto.constant_time_compare only call ord on non ints.
--------------------------+------------------------------------
     Reporter:  adsworth  |                    Owner:  adsworth
         Type:  Bug       |                   Status:  new
    Component:  Python 3  |                  Version:  1.3
     Severity:  Normal    |               Resolution:
     Keywords:            |             Triage Stage:  Accepted
    Has patch:  1         |      Needs documentation:  0
  Needs tests:  0         |  Patch needs improvement:  1
Easy pickings:  0         |                    UI/UX:  0
--------------------------+------------------------------------
Changes (by lukeplant):

 * needs_better_patch:   => 1
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Accepted. But doing an `isinstance` check for each element seems like a
 pretty inefficient approach. The function is short enough that we are
 probably better of conditionally defining a different function for Python
 3.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17040#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to