#17097: Permission to delete a comment should be based on a user's given
permissions
----------------------------------+------------------------------------
     Reporter:  george@…          |                    Owner:  nobody
         Type:  New feature       |                   Status:  new
    Component:  contrib.comments  |                  Version:  1.3
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  1                 |      Needs documentation:  1
  Needs tests:  1                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+------------------------------------
Changes (by julien):

 * needs_docs:   => 1
 * needs_better_patch:   => 0
 * type:  Bug => New feature
 * needs_tests:   => 1
 * stage:  Unreviewed => Accepted


Comment:

 I agree that it would make sense to use the delete permissions here. This
 would need some tests. Also, a note on the patch:
 `ModelAdmin.has_delete_permission()` should probably be used instead of
 hardcoding the permission name.

 Finally, this would be backwards-incompatible and would require a mention
 in the release notes.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17097#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to