#16507: Tests that alter ROOT_URLCONF should set DEBUG_PROPAGATE_EXCEPTION
----------------------------------+------------------------------------
Reporter: andymckay | Owner: nobody
Type: Bug | Status: reopened
Component: contrib.messages | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Comment (by andymckay):
* I misspelled DEBUG_PROPAGATE_EXCEPTIONS in my code. If you add the S on
the end, you can flip it and the test will flip between pass and fail,
sorry about that.
* The wrong handler is called, I was trying to boil this down to a one
file test case. You can move the assignment to handler500 around it
doesn't matter. The problem as Carl said is that we don't have a complete
isolation in the test, we are altering some parts (the urls) but not
others (the handlers). If you need a more comprehensive example I can
point you at code in my projects that trigger this.
I would like to take it one step further though and suggest that
DEBUG_PROPAGATE_EXCEPTIONS should be set to False for all tests. It can
then be turned on when needed. It's only used in one place,
core/handlers.py handle_uncaught_exception. That should have its own set
of tests and have good coverage, with that flag turned on for those test.
Perhaps there might be an integration test or two.
But, everywhere else does not need to be testing how well
handle_uncaught_exception works, that is out of scope. In the given
example we just need to know that a MessageFailure is raised. Nothing
else. But perhaps that's a seperate bug.
--
Ticket URL: <https://code.djangoproject.com/ticket/16507#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
