#17218: Select Filter (its "to" box) has 0 height if in a collapsed fieldset
-----------------------------------+-------------------------------------
     Reporter:  jimallman <jim@…>  |                    Owner:  jimallman
         Type:  Bug                |                   Status:  new
    Component:  contrib.admin      |                  Version:  SVN
     Severity:  Release blocker    |               Resolution:
     Keywords:  fieldset           |             Triage Stage:  Accepted
    Has patch:  1                  |      Needs documentation:  0
  Needs tests:  1                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  1
-----------------------------------+-------------------------------------
Changes (by jimallman <jim@…>):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 OK, I've submitted a pull request to django/django on Github:
  https://github.com/django/django/pull/83
 I've run the modified `collapse.js` through the Closure Compiler, as
 requested. I don't have automated tests for this, sorry.

 '''To see this pull request as a patch''':
  https://github.com/django/django/pull/83.diff

 Note that toggling a collapsible fieldset will now fire new custom jQuery
 events (`show.fieldset` and `hide.fieldset`) to all its child elements.
 This should come in handy for other widgets that need to adjust their
 placement or dimensions. See the changes to `SelectFilter2.js` for an
 example of binding widgets to respond to these events.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17218#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to