#17032: Tests for contrib.auth fail if login signals use templates
-------------------------------------+-------------------------------------
     Reporter:  jMyles               |                    Owner:  jMyles
         Type:  Bug                  |                   Status:  closed
    Component:  Testing framework    |                  Version:  1.3
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  contrib.auth, tests  |             Triage Stage:
    Has patch:  1                    |  Unreviewed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by anonymous):

 Although the larger issue of conflation of integration and unit testing is
 an important topic of discussion, it seems to me that this patch makes
 good sense no matter what path is chosen.  In fact, it seems to me that
 overriding settings.TEMPLATE_DIRS is simply an oversight; I don't see that
 it reflects any underlying intention to separate unit tests from
 integration tests.

 In any case, this patch will not inhibit a later, more perfect solution,
 and will likely be part of it, no?

 The consequence of failing to accept this patch or one like it is that
 anybody using a template with the login signal is going to have errors in
 the testrunner.  Is that OK?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17032#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to