#17325: Add **kwargs to is_valid and several validation methods
-------------------------------------+-------------------------------------
     Reporter:  jorgeecardona        |                    Owner:  nobody
         Type:  New feature          |                   Status:  new
    Component:  Forms                |                  Version:  1.3
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Design
    Has patch:  0                    |  decision needed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * component:  Uncategorized => Forms
 * stage:  Unreviewed => Design decision needed


Comment:

 If I understand correctly, you'd want `Form.is_valid` to accept any
 keyword arguments and pass them to `Form.full_clean`.

 I'm not convinced it's a good idea, because it's implicit, while passing
 arguments to the constructor is explicit — everything is visible in your
 `Form` subclass.

 Furthermore, that would be difficult to achieve with the current
 implementation: `Form.is_valid` accesses the property `Form.errors`, which
 triggers the call to `Form.full_clean`. But you can't pass arguments to a
 property. So it isn't obvious that this change can be done without
 breaking backwards compatibility.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17325#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to