#2879: Add live test server support to test framework
-------------------------------------+-------------------------------------
Reporter: Mikeal Rogers | Owner: devin
<mikeal@…> | Status: new
Type: New feature | Version:
Component: Testing framework | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
Replying to [comment:76 jezdez]:
> - In `AdminSeleniumWebDriverTestCase` (shorter name?) the `setUp` method
re-imports and instantiates the webdriver for every test method. Using the
setUpClass class method would be preferred (unless I'm missing some need
for resetting it all the time).
Agreed. I've made that change in the latest patch.
> - The new `LIVE_TEST_SERVER_HOST` and `LIVE_TEST_SERVER_PORT` settings
are much too specific for Selenium (including the fact that "http" is
hardcoded in `LiveServerTestCase`). I suggest introducing justa
`LIVE_TEST_SERVER` setting instead and ask the users to give it a full
URL, e.g. 'http://localhost/8081/'). Even though we have separate settings
for email servers (`EMAIL_HOST` and `EMAIL_PORT`) the live test server has
a lax API and shouldn't be hardwired to require protocol, host and port.
Internally the `WSGIServer` opens a socket and binds it to a server
address that has to be a pair (host, port), so we might have to keep that
API too. What do you think?
> - The docs don't mention how to run the Selenium based tests except
installing the selenium Python library. I suggest to add a small section
about how to get Selenium to run in the first place (basically only where
to download and how to run, like mentioned on
http://pypi.python.org/pypi/selenium).
As discussed on IRC, it is really as simple as installing the selenium
package. The documentation could perhaps be improved, but it already
contains all you need to get started.
Finally, in the latest patch I've moved the live server tests to the
already existing 'servers' app, and made a few small tweaks to the admin
selenium tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/2879#comment:83>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
