#16919: Pass user to set_password_form in GET requests
------------------------------+------------------------------------
     Reporter:  jaimeirurzun  |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  1.3
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  1             |  Patch needs improvement:  0
Easy pickings:  0             |                    UI/UX:  0
------------------------------+------------------------------------
Changes (by ejucovy):

 * cc: ethan.jucovy@… (added)


Comment:

 I have another use case for this: rendering the user's name in the
 `registration/password_reset_confirm.html` template.

 Currently the `password_reset_confirm` view does not provide "user" as a
 template context variable, nor even "uidb36" and "token".  Since the form
 also doesn't have the user object stored on a GET request, this means that
 there's no way for the template to say "{% if validlink %} Hello, {{
 user.username }} -- reset your password here {% endif %}" -- short of
 forking the view, or some pretty hacky middleware that re-parses the
 request URL and re-fetches the user from the given uid+token.

 I see that the "needs_tests" flag is set on this ticket .. what sort of
 test would be required for this patch to be merged?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16919#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to