#11739: ContentFile() does not support unicode data
--------------------------------------+------------------------------------
     Reporter:  adamnelson            |                    Owner:  nobody
         Type:  Bug                   |                   Status:  reopened
    Component:  File uploads/storage  |                  Version:  1.1
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by claudep):

 Thanks for those tests!

 What worries me in your patch, Cody, is that you are excluding cStringIO
 not only for !ContentFile, but for the plain File class. I guess that
 !ContentFile is mainly used in tests, where performance is less a concern
 (I see only one use in Django code, related to the collectstatic
 management command).

 That's why I think the code which should also be tested performance-wise
 is the __iter__ method of the File object.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/11739#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to