#17663: Method "save" in BaseModelFormSet is not marked as alters_data
-------------------------+------------------------------------
Reporter: aiv | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: SVN
Severity: Normal | Resolution:
Keywords: formset | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------+------------------------------------
Changes (by akaariai):
* cc: anssi.kaariainen@… (added)
* needs_better_patch: => 0
* needs_tests: => 1
* easy: 0 => 1
* needs_docs: => 0
* stage: Unreviewed => Accepted
Comment:
Makes sense. I wonder if this kind of patch needs tests. We don't have
tests for the existing .alters_data ones. Adding a test is of course easy,
just check that the function's alters_data attr is True. So, my initial
feeling is why not? I guess the right place is in
regressiontests/model_forms_regress/tests.py
--
Ticket URL: <https://code.djangoproject.com/ticket/17663#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
