#17673: Forbid field shadowing in model multi-inheritance
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.3
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: validation | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by akaariai):
The clash variable is the clashing field, not a boolean. It is later on
used (actually in the second snippet above). The last "or None" is
redundant so it could be removed. The variable should probably be named
clashing_field, so there would not be confusion.
I think the PEP8 makes sense, as do the renames.
You are absolutely correct that the `StudentWorker` model should be
removed completely. I should have done that.
If you feel like it you can upgrade the patch. If you see places which are
hard to understand add comments or ask for me to do that. In my opinion
that is the best way to make sure the code is understandable - the
reviewer adding comments to places where he has to think "too much".
Anyways, thanks for the feedback!
--
Ticket URL: <https://code.djangoproject.com/ticket/17673#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
