#17737: collectstatic copies wrong files to STATIC_ROOT
-------------------------------------+------------------------------------
     Reporter:  pigletto             |                    Owner:  jezdez
         Type:  Bug                  |                   Status:  new
    Component:  contrib.staticfiles  |                  Version:  1.3
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+------------------------------------

Comment (by pigletto):

 Replying to [comment:3 slinkp]:
 > The second time you run, the file.js in appB/something_else is found
 first again, but skipped because it's not modified.  Then the
 AppDirectoriesFinder runs, and the file.js in appA/static is found, but
 this time "file.js" is not in self.copied_files, and self.delete_file()
 finds that it's more recent than the one we collected on the previous run.
 > So appA wins.
 >
 > If I understand the original bug report correctly, this variant should
 be fixed on trunk too.
 I think that you're right there but I just started to wonder about
 slightly different way to get wrong results with collectstatic, even with
 trunk version(!).

 According to your example structure: if appA/static/file.js will be
 modified '''after''' collectstatic was run, then, even in trunk version,
 it will be copied to STATIC_ROOT, because it's modification date will be
 newer than modification date of STATIC_ROOT/file.js.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17737#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to