#17834: ETag generated from empty content can break http caching
-------------------------------------+-------------------------------------
     Reporter:  paulegan             |                    Owner:  nobody
         Type:  Bug                  |                   Status:  reopened
    Component:  HTTP handling        |                  Version:  1.3
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Design
    Has patch:  1                    |  decision needed
  Needs tests:  1                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by claudep):

 * status:  closed => reopened
 * resolution:  wontfix =>
 * stage:  Accepted => Design decision needed


Comment:

 At this point, I see 3 ways to solve this:

 1. Consider it is a corner case, and let the programmers handle
 patch_response_headers carefully for responses without content.
 2. Change ETag computing to always include headers (generates digest on
 str(response) instead of str(response.content)).
 3. Special case ETag computing to use headers only if response.content is
 empty (OP proposal).

 Note also that I have refactored ETag computing in a patch on #14722.
 Marking as DDN to get a core committer opinion.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17834#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to