#17795: kwargs not passed on by django.views.generic.edit import ProcessFormView
-------------------------------------+-------------------------------------
Reporter: ed.crewe@… | Owner: Fandekasp
Type: | Status: new
Cleanup/optimization | Version:
Component: Generic views | 1.4-beta-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by julien):
* needs_better_patch: 0 => 1
Comment:
The patch looks good. If you could add tests for `BaseDateListView` that
would be great. Also some minor comments:
* Verify the actual value of the 'foo' context variables instead of just
verifying their existence.
* Instead of updating `kwargs` (e.g.: `kwargs['form'] = form`) before
passing it to `self.get_context_data()`, use named arguments, i.e.:
`self.get_context_data(form=form, **kwargs)`, mainly for consistency with
the rest of the codebase.
--
Ticket URL: <https://code.djangoproject.com/ticket/17795#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
