#18133: global settings for label_suffix
-------------------------------------+-------------------------------------
Reporter: Evil Clay | Owner: nobody
<clay.evil@…> | Status: closed
Type: New feature | Version: 1.4
Component: Uncategorized | Resolution: wontfix
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by carljm):
Replying to [comment:5 Evil Clay <clay.evil@…>]:
> it's your framework so it is your call. But IMHO overriding a framework
class that was not primary designed to be overridable (hence is not
abstract and is not documented to be ovveridable) is not a clean nor
elegant solution.
Huh? `Form` is used only by subclassing, that's what it's for.
> In next version of Django, when you add an important argument to the
unity method, it will render this solution useless, or will introduce a
problem to my project which may be hard to find. So i will have to keep
track of this "solution" in the documentation hence it can't be an elegant
solution.
That's why you should use `**kwargs` instead, to avoid this problem.
> P.S. If you don't want to introduce settings, you can design some
structure that can be overridden by design and will be documented as to be
overridden if such a change is needed. I'm a Java programer, so python is
not my home language so i cannot yet design this kind of machinery, but
python is a very magical language, i'm sure that a better design exists.
Not every little tweak needs its own separate overridable method. An
`__init__` argument is appropriate for this.
Please take further discussion (if necessary) to a mailing list thread, or
usage/Python questions to the appropriate fora. Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/18133#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
