#17788: bulk_create() "too many SQL variables" error
-------------------------------------+-------------------------------------
Reporter: alpar | Owner: akaariai
Type: Bug | Status: new
Component: Database layer | Version:
(models, ORM) | 1.4-beta-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by koniiiik):
Overall the patch looks good to me, only one remark: personally I'd use a
non-recursive implementation of `_batched_insert`. Maybe it's just me just
being excessively reluctant to use recursion when it can be rewritten 1:1
into a loop. Also, in extreme cases where the number of batches is high,
the running time of this method will be O(n²) as a new copy of the whole
list of remaining objects is created in each iteration.
Anyway, I don't know how much of an issue these concerns are.
--
Ticket URL: <https://code.djangoproject.com/ticket/17788#comment:45>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
