#18764: HttpResponse._get_content shouldn't accept non-text types -------------------------------------+------------------------------------- Reporter: aaugustin | Owner: aaugustin Type: Bug | Status: closed Component: HTTP handling | Version: master Severity: Release blocker | Resolution: fixed Keywords: | Triage Stage: Ready for Has patch: 1 | checkin Needs tests: 0 | Needs documentation: 0 Easy pickings: 0 | Patch needs improvement: 0 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by Aymeric Augustin <aymeric.augustin@…>): In [2892cb0ec4ebde4955f12c92183b7804558ca381]: {{{ #!CommitTicketReference repository="" revision="2892cb0ec4ebde4955f12c92183b7804558ca381" [py3] Fixed regression introduced in 536b030363. Refs #18764. Reverted 536b030363 and switched to a more explicit way of avoiding calling bytes(<int>). This definitely deserves a refactoring. Specifically, _get_content should just return b''.join(self). Unfortunately that's impossible with the current tests. }}} -- Ticket URL: <https://code.djangoproject.com/ticket/18764#comment:6> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.