#18860: GET-parameters in `path` argument of `django.test.client.Client.get`
------------------------------------+--------------------------------------
     Reporter:  lagunov.vladimir@…  |                    Owner:  nobody
         Type:  Bug                 |                   Status:  new
    Component:  Testing framework   |                  Version:  1.4
     Severity:  Normal              |               Resolution:
     Keywords:  Client              |             Triage Stage:  Unreviewed
    Has patch:  1                   |      Needs documentation:  0
  Needs tests:  0                   |  Patch needs improvement:  0
Easy pickings:  0                   |                    UI/UX:  0
------------------------------------+--------------------------------------
Changes (by claudep):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 The current behaviour is explicitely tested:[[BR]]
 
https://github.com/django/django/blob/master/tests/regressiontests/test_client_regress/tests.py#L822

 It was introduced in:[[BR]]
   https://github.com/django/django/commit/95d8c0619a

 and documented:[[BR]]
 
https://docs.djangoproject.com/en/dev/topics/testing/#django.test.client.Client.get
 [[BR]]
   ("If you provide a URL with both an encoded GET data and a data
 argument, the data argument will take precedence.")

 To me, your proposal makes sense. But I'd like to get the opinion of
 Russell (committer of changeset above) before moving on.

 P.S. Please provide patches as unified diff format.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18860#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to